Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 11, 2013 at 7:08 PM, Bjørn Mork <bjorn@xxxxxxx> wrote:
>
> The docs for usb_submit_urb() in drivers/usb/core/urb.c lists some
> possible mem_flags use cases. Among these are (where (b) and (c) are
> cases needing GFP_ATOMIC and not applicable here):
>
> <quote>
>  *  (3) If you use a kernel thread with a network driver you must use
>  *      GFP_NOIO, unless (b) or (c) apply;
> </quote>
>
> Is this example
>  a) wrong, or
>  b) not applicable, or
>  c) to be excluded from the new API?

IMO, it may be a) or b), and we can find many GFP_KERNEL usage
inside usbnet(kevent(), ...).

Also (3) doesn't explain the cause. Oliver, could you give a hit?

Wrt. usbnet, except for in xmit & receive handler, the rule should be
same with other usb driver.

Thanks,
-- 
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux