On 04/11/2013 01:04 PM, Felipe Balbi wrote: > Hi, > > On Thu, Apr 11, 2013 at 12:42:04PM +0300, Roger Quadros wrote: >> Hi Greg, >> >> The following patch gets rid of Kbuild warnings when USB_EHCI_HCD_OMAP >> is enabled. >> >> Patch is based on your usb-next branch and is needed for 3.10. >> >> From: Roger Quadros <rogerq@xxxxxx> >> Date: Thu, 11 Apr 2013 12:08:19 +0300 >> Subject: [PATCH] USB: ehci-omap: Select USB_PHY >> >> As we need NOP_USB_XCEIV which depends on USB_PHY >> we need to select USB_PHY as well. >> >> Gets rid of the below warnings when USB_EHCI_HCD_OMAP >> is enabled. >> >> warning: (USB_EHCI_HCD_OMAP) selects NOP_USB_XCEIV which has unmet direct dependencies (USB_SUPPORT && USB_PHY) >> warning: (USB_EHCI_HCD_OMAP) selects NOP_USB_XCEIV which has unmet direct dependencies (USB_SUPPORT && USB_PHY) >> >> Signed-off-by: Roger Quadros <rogerq@xxxxxx> > > Ideally, however, we wouldn't select any PHY in particular as different > boards might need a different PHY driver, even on OMAP ;-) > Right, but we need to select USB_PHY here as the driver uses the USB_PHY APIs. The NOP_USB_XCEIV selection could be done by the board config. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
