On Thu, Apr 11, 2013 at 5:53 PM, Oliver Neukum <oliver@xxxxxxxxxx> wrote: > On Thursday 11 April 2013 16:09:16 Ming Lei wrote: >> >> Could you explain why work queue need GFP_NOIO? > > Your fix for the memory allocation depends on it happening in the same > context. If you execute code on a work queue this happens in the context > of a kernel thread. I understand the interface might be called from workqueue, and my question is why GFP_NOIO is needed in the work queue context. Generally speaking, GFP_KERNEL is enough for work queue context. As we discussed before, GFP_NOIO is required in runtime resume context and reset context, and the two contexts have been addressed automatically. So looks you didn't answer my question, :-) I mean if GFP_NOIO isn't needed, we can use GFP_KERNEL directly, and the extra parameter isn't need. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html