Re: [PATCH 1/2 v4] usbnet: allow status interrupt URB to always be active

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 10 April 2013 10:01:20 Dan Williams wrote:
> On Wed, 2013-04-10 at 15:58 +0200, Oliver Neukum wrote:
> > On Wednesday 10 April 2013 08:54:43 Dan Williams wrote:
> > > > The refcounting is very good. Just don't mess around with "force"
> > > 
> > > That's easy to do if the helpers aren't used for suspend/resume, which
> > > is what I had previously in my v2 patches until Ming suggested that I
> > > use the helpers there.  I can go back to that approach if you'd like, it
> > > is a bit less complicated at the expense of sprinkling the interrupt urb
> > > submit/kill code around more widely.
> > 
> > If you introduce a third helper like "forcibly_stop_interrupt" or something,
> > I'll be perfectly happy. Just don't use flags which completely alter behavior.
> > 
> > 	Regards
> > 		Oliver
> 
> Do you mean something more like this?  If so, I'll go ahead and do the
> formal submission.  Thanks!

That looks good and ready.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux