Re: [PATCH v2] staging: dwc2: toggle periodic debugging output separately

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Apr 09, 2013 at 07:35:33PM +0200, Matthijs Kooijman wrote:
> > > This adds a config option USB_DWC2_DEBUG_PERIODIC that allows debugging
> > > output be suppressed for periodic transfers. This helps when debugging
> > > non-periodic transfers while there are also periodic transfers going on
> > > (both to make the debug output less polluted and to prevent all CPU time
> > > going to debug messages).
> > > [...]
> > > Signed-off-by: Matthijs Kooijman <matthijs@xxxxxxxx>
> >
> > why don't you just use dynamic printk instead ?
> In some cases, this could help, but a lot of the prints modified by this
> patch are used for both periodic and non-periodic transfers. AFAIU, with
> dynamic printks you could only enable/disable them altogether, not based
> on some arbitrary condition (e.g., the urb being handled is targeted at
> a periodic endpoint or not).

you can enable prints line-by-line

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux