Re: [PATCH v2 04/11] usb: musb: gadget: remove hcd initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>> "Daniel" == Daniel Mack <zonque@xxxxxxxxx> writes:

 Daniel> This will be done from a more appropriate location and as it doesn't
 Daniel> work anyway, it can safely be removed before the other changes.

 Daniel> Signed-off-by: Daniel Mack <zonque@xxxxxxxxx>

Acked-by: Peter Korsgaard <jacmet@xxxxxxxxxx>

 Daniel> ---
 Daniel>  drivers/usb/musb/musb_gadget.c | 10 ----------
 Daniel>  1 file changed, 10 deletions(-)

 Daniel> diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
 Daniel> index ba70923..0414bc1 100644
 Daniel> --- a/drivers/usb/musb/musb_gadget.c
 Daniel> +++ b/drivers/usb/musb/musb_gadget.c
 Daniel> @@ -1820,7 +1820,6 @@ static int musb_gadget_start(struct usb_gadget *g,
 Daniel>  {
 Daniel>  	struct musb		*musb = gadget_to_musb(g);
 Daniel>  	struct usb_otg		*otg = musb->xceiv->otg;
 Daniel> -	struct usb_hcd		*hcd = musb_to_hcd(musb);
 Daniel>  	unsigned long		flags;
 Daniel>  	int			retval = 0;
 
 Daniel> @@ -1847,17 +1846,9 @@ static int musb_gadget_start(struct usb_gadget *g,
 Daniel>  	 * handles power budgeting ... this way also
 Daniel>  	 * ensures HdrcStart is indirectly called.
 Daniel>  	 */
 Daniel> -	retval = usb_add_hcd(hcd, 0, 0);
 Daniel> -	if (retval < 0) {
 Daniel> -		dev_dbg(musb->controller, "add_hcd failed, %d\n", retval);
 Daniel> -		goto err;
 Daniel> -	}
 Daniel> -
 Daniel>  	if (musb->xceiv->last_event == USB_EVENT_ID)
 Daniel>  		musb_platform_set_vbus(musb, 1);
 
 Daniel> -	hcd->self.uses_pio_for_control = 1;
 Daniel> -
 Daniel>  	if (musb->xceiv->last_event == USB_EVENT_NONE)
 Daniel>  		pm_runtime_put(musb->controller);
 
 Daniel> @@ -1942,7 +1933,6 @@ static int musb_gadget_stop(struct usb_gadget *g,
 Daniel>  	musb_platform_try_idle(musb, 0);
 Daniel>  	spin_unlock_irqrestore(&musb->lock, flags);
 
 Daniel> -	usb_remove_hcd(musb_to_hcd(musb));
 Daniel>  	/*
 Daniel>  	 * FIXME we need to be able to register another
 Daniel>  	 * gadget driver here and have everything work;
 Daniel> -- 
 Daniel> 1.8.1.4



-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux