Hi Paul, > But you really need to split this into a more manageable series of > patches. It's really difficult to review when you have so many different > things all munged together like this. It's also discouraging to potential > reviewers to see one set of 41 patches, where if it was four series of 10 > patches each it seems like much less work ;) I had thought about that, but the fact that the patch series wouldn't be free of dependencies made me believe that just sending over a big lump of patches to collect some feedback first and then resend smaller series of patches with favorable reviews was a good idea. Looking back, I see your point. I'll see if I can find some themes to split up these patches. > You are using the wrong style for multi-line comments. Please read > Documentation/CodingStyle to see the right way to do it. Also, please run > all your patches thru checkpatch.pl before submitting them, that would > have caught this problem. Hmm, I guess I should re-read SubmittingPatches and SubmitChecklist, sorry for that :-) > I see in some of the patches you don't have any commit message other than > the subject line. Apparently that is a no-no, at least Felipe objected > when I submitted some patches like that. At a minimum just rephrase the > subject line a bit in the body of the patch email. Ok, willdo. I'll try to resend the patches in multiple series today. I'll also include the suggestions from Sergei right away. Gr. Matthijs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
