Each of the parameters in the dwc2_core_params struct can now be changed
using devicetree parameters.
Signed-off-by: Matthijs Kooijman <matthijs@xxxxxxxx>
---
Documentation/devicetree/bindings/staging/dwc2.txt | 36 ++++++++++++
drivers/staging/dwc2/platform.c | 68 ++++++++++++++++++++++
2 files changed, 104 insertions(+)
Does it make sense to set all these properties in the devicetree?
diff --git a/Documentation/devicetree/bindings/staging/dwc2.txt b/Documentation/devicetree/bindings/staging/dwc2.txt
index 3649c88..05d9c08 100644
--- a/Documentation/devicetree/bindings/staging/dwc2.txt
+++ b/Documentation/devicetree/bindings/staging/dwc2.txt
@@ -5,6 +5,39 @@ Required properties:
- compatible : "snps,dwc2"
- reg : Should contain 1 register range (address and length)
- interrupts : Should contain 1 interrupt
+Optional properties:
+ - dma-enable
+ - otg-cap
+ - otg-ver
+ - dma-enable
+ - dma-desc-enable
+ - speed
+ - enable-dynamic-fifo
+ - en-multiple-tx-fifo
+ - host-rx-fifo-size
+ - host-nperio-tx-fifo-size
+ - host-perio-tx-fifo-size
+ - max-transfer-size
+ - max-packet-count
+ - host-channels
+ - phy-type
+ - phy-utmi-width
+ - phy-ulpi-ddr
+ - phy-ulpi-ext-vbus
+ - i2c-enable
+ - ulpi-fs-ls
+ - host-support-fs-ls-low-power
+ - host-ls-low-power-phy-clk
+ - ts-dline
+ - reload-ctl
+ - ahb-single
+
+Each of the above properties take a single cell containing an integer. See
+struct dwc2_core_params in dwc2/core.h for their meanings and possible values.
+
+If absent, these values have either a driver default or are autodetected.
+Where possible, the values set through the devicetree are checked against
+hardware limits and automatically capped or adjusted as needed.
Example:
@@ -12,4 +45,7 @@ Example:
compatible = "ralink,rt3050-otg, snps,dwc2";
reg = <0x101c0000 40000>;
interrupts = <18>;
+
+ # Force slave mode, even when dma is advertised to work
+ dma-enable = <0>;
};
diff --git a/drivers/staging/dwc2/platform.c b/drivers/staging/dwc2/platform.c
index 0ffb1b3..be5df0c 100644
--- a/drivers/staging/dwc2/platform.c
+++ b/drivers/staging/dwc2/platform.c
@@ -40,6 +40,7 @@
#include <linux/slab.h>
#include <linux/dma-mapping.h>
#include <linux/platform_device.h>
+#include <linux/of.h>
#include "core.h"
#include "hcd.h"
@@ -69,6 +70,70 @@ static int dwc2_driver_remove(struct platform_device *dev)
}
/**
+ * dwc2_load_property() - Load a single property from the devicetree
+ * node into the given variable.
+ *
+ * @dev: Platform device
+ * @res: The variable to put the loaded value into
+ * @name: The name of the devicetree property to load
+ */
+static void dwc2_load_property(struct platform_device *dev, int *res, const char *name)
+{
+ int len;
+ const u32 *val;
+
+ val = of_get_property(dev->dev.of_node, name, &len);
+ if (!val)
+ return;
+
+ if (len != sizeof(*val)) {
+ dev_warn(&dev->dev, "Invalid value in devicetree for %s property, should be a single integer\n", name);
+ return;
+ }
+
+ *res = be32_to_cpu(*val);
+
+ dev_dbg(&dev->dev, "Loaded %s parameter from devicetree: %d\n", name, *res);
+}
+
+/**
+ * dwc2_load_properties() - Load all devicetree properties into the core
+ * params.
+ *
+ * @dev: Platform device
+ * @params: The core parameters to load the values into
+ */
+static void dwc2_load_properties(struct platform_device *dev, struct dwc2_core_params *params)
+{
+ dev_dbg(&dev->dev, "Loading parameters from devicetree node %s\n", dev->dev.of_node->name);
+ dwc2_load_property(dev, ¶ms->dma_enable, "dma-enable");
+ dwc2_load_property(dev, ¶ms->otg_cap, "otg-cap");
+ dwc2_load_property(dev, ¶ms->otg_ver, "otg-ver");
+ dwc2_load_property(dev, ¶ms->dma_enable, "dma-enable");
+ dwc2_load_property(dev, ¶ms->dma_desc_enable, "dma-desc-enable");
+ dwc2_load_property(dev, ¶ms->speed, "speed");
+ dwc2_load_property(dev, ¶ms->enable_dynamic_fifo, "enable-dynamic-fifo");
+ dwc2_load_property(dev, ¶ms->en_multiple_tx_fifo, "en-multiple-tx-fifo");
+ dwc2_load_property(dev, ¶ms->host_rx_fifo_size, "host-rx-fifo-size");
+ dwc2_load_property(dev, ¶ms->host_nperio_tx_fifo_size, "host-nperio-tx-fifo-size");
+ dwc2_load_property(dev, ¶ms->host_perio_tx_fifo_size, "host-perio-tx-fifo-size");
+ dwc2_load_property(dev, ¶ms->max_transfer_size, "max-transfer-size");
+ dwc2_load_property(dev, ¶ms->max_packet_count, "max-packet-count");
+ dwc2_load_property(dev, ¶ms->host_channels, "host-channels");
+ dwc2_load_property(dev, ¶ms->phy_type, "phy-type");
+ dwc2_load_property(dev, ¶ms->phy_utmi_width, "phy-utmi-width");
+ dwc2_load_property(dev, ¶ms->phy_ulpi_ddr, "phy-ulpi-ddr");
+ dwc2_load_property(dev, ¶ms->phy_ulpi_ext_vbus, "phy-ulpi-ext-vbus");
+ dwc2_load_property(dev, ¶ms->i2c_enable, "i2c-enable");
+ dwc2_load_property(dev, ¶ms->ulpi_fs_ls, "ulpi-fs-ls");
+ dwc2_load_property(dev, ¶ms->host_support_fs_ls_low_power, "host-support-fs-ls-low-power");
+ dwc2_load_property(dev, ¶ms->host_ls_low_power_phy_clk, "host-ls-low-power-phy-clk");
+ dwc2_load_property(dev, ¶ms->ts_dline, "ts-dline");
+ dwc2_load_property(dev, ¶ms->reload_ctl, "reload-ctl");
+ dwc2_load_property(dev, ¶ms->ahb_single, "ahb-single");
+}
+
+/**
* dwc2_driver_probe() - Called when the DWC_otg core is bound to the DWC_otg
* driver
*
@@ -111,6 +176,9 @@ static int dwc2_driver_probe(struct platform_device *dev)
return -EINVAL;
}
+ if (dev->dev.of_node)
+ dwc2_load_properties(dev, ¶ms);
+
hsotg->regs = devm_ioremap_resource(&dev->dev, res);
if (IS_ERR(hsotg->regs))
return PTR_ERR(hsotg->regs);
--
1.8.0
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
