Peter Chen <peter.chen@xxxxxxxxxxxxx> writes: > On Tue, Apr 02, 2013 at 11:31:47AM +0200, Michael Grzeschik wrote: >> > > dma_pool_destroy(ci->td_pool); >> > > free_qh_pool: >> > > - dma_pool_destroy(ci->qh_pool); >> > >> > You may need dma_free_coherent. >> >> Will add that here. >> > > The same for de-init procedure. > >> > > -} __attribute__ ((packed, aligned(4))); >> > > +} __attribute__ ((packed, aligned(64))); >> > > >> > > /** >> > > * struct ci13xxx_req - usb request representation >> > > -- >> > > 1.8.2.rc2 >> > > I still not see too much meaningful for this patch, it just reduces > some memory usage (compared 4K usage currently), and you use > compiler to make sure aligned, but not at code. > > Let's Alex decide it. I actually had a similar patch a year ago when I started converting the old chipidea driver, one reason was that some chipideas have a few kilobytes of integrated sram, which you can make available to the driver by using dma coherent allocator and dma_declare_coherent_memory(). I gave up on it because it gave zero performance increase (that I could detect) though. Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
