Re: [PATCH v9 7/8] usb: chipidea: udc: prepare qhead with dma_alloc_coherent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 02, 2013 at 11:31:47AM +0200, Michael Grzeschik wrote:
> > >  	dma_pool_destroy(ci->td_pool);
> > >  free_qh_pool:
> > > -	dma_pool_destroy(ci->qh_pool);
> > 
> > You may need dma_free_coherent.
> 
> Will add that here.
> 

The same for de-init procedure.

> > > -} __attribute__ ((packed, aligned(4)));
> > > +} __attribute__ ((packed, aligned(64)));
> > >  
> > >  /**
> > >   * struct ci13xxx_req - usb request representation
> > > -- 
> > > 1.8.2.rc2
> 

I still not see too much meaningful for this patch, it just reduces
some memory usage (compared 4K usage currently), and you use
compiler to make sure aligned, but not at code.

Let's Alex decide it.

-- 

Best Regards,
Peter Chen

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux