On Mon 2013-01-21 10:05:06, Felipe Balbi wrote: > Hi, > > On Sun, Jan 20, 2013 at 11:17:31AM +0100, Pali Rohár wrote: > > On Sunday 20 January 2013 10:25:37 Felipe Balbi wrote: > > > On Sun, Jan 20, 2013 at 03:58:13AM +0100, Pali Rohár wrote: > > > > Signed-off-by: Pali Rohár <pali.rohar@xxxxxxxxx> > > > > > > NAK for two reasons: > > > > > > a) the original Nokia kernel used a separate g_file_storage > > > gadget to use Mass Storage mode, use that > > > > > > b) there is no commit log > > > > Reason why add mass storage mode to g_nokia is to avoid switching > > between g_{file,mass}_storage and g_nokia and to have one gadget > > driver for Nokia N900. It is better to have usb network and mass > > storage mode in one driver (and not to unload & load another). > > > > I tested this patch with 3.8-rc3 kernel on Nokia N900 and usb > > network with mass storage mode working without problems. > > Doesn't matter, in this case this is something which nokia wrote to > carry on their Maemo/MeeGo devices so unless someone from Nokia says > this is how they want to use nokia.c from now on, I can't simply risk > breaking all other users for your own convenience. Nokia is unlikely to continue linux development, sorry. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html