On Sunday 20 January 2013 10:25:37 Felipe Balbi wrote:
> On Sun, Jan 20, 2013 at 03:58:13AM +0100, Pali Rohár wrote:
> > Signed-off-by: Pali Rohár <pali.rohar@xxxxxxxxx>
>
> NAK for two reasons:
>
> a) the original Nokia kernel used a separate g_file_storage
> gadget to use Mass Storage mode, use that
>
> b) there is no commit log
Reason why add mass storage mode to g_nokia is to avoid switching
between g_{file,mass}_storage and g_nokia and to have one gadget
driver for Nokia N900. It is better to have usb network and mass
storage mode in one driver (and not to unload & load another).
I tested this patch with 3.8-rc3 kernel on Nokia N900 and usb
network with mass storage mode working without problems.
--
Pali Rohár
pali.rohar@xxxxxxxxx
Attachment:
signature.asc
Description: This is a digitally signed message part.
