On Wed, Mar 20, 2013 at 10:18:03AM +0800, Lan Tianyu wrote: > On 2013年03月20日 03:06, Sarah Sharp wrote: > > Ok, this looks sane, and our Intel testers report it doesn't oops like > > v2. The patch description on the first patch is better as well. > > > > Tianyu, I know this introduces a new API to the host controller driver > > structure, and we would normally queue these two patches for 3.10. > > > > However, I know a lot of the port power off code went into 3.9. If we > > don't have these patches in 3.9, what will be the impact? Will we say, > > misassign a power resource from a particular port, or mismark a USB port > > connection type? Is there any user-level impact if we don't have these > > in 3.9? > > > > If these patches should go into 3.9, should they also be backported to > > 3.8 and 3.7? Commit d557542421da643358201664903e67fd01dfca1a > > "usb/acpi: Bind ACPI node to USB port, not usb_device." was first > > introduced in 3.7, and it looks like the sysfs files to turn on and off > > ports were added in 3.7 as well. Without these two patches, will > > that sysfs interface work correctly? > > I think there is an impact for usb3.0 paired ports. So it's better to > backport these patchs to 3.7, 3.8, 3.9 if possible. These patches also > depend on the commit 1033f9041d "ACPI: Allow ACPI binding with USB-3.0 > hub". I'd like to take the job if I could do. I'm not sure what you mean by "I'd like to take the job if I could do." If you are talking about backporting patches to stable, I'll just mark your two patches to Cc the stable mailing list, and Greg will automatically backport this when it hits Linus' tree. There's no work for you or I to do, unless the patches don't apply. > BTW, the sysfs files to turn on and off ports has been reverted by Greg > in v3.7. If the sysfs files were reverted for 3.7, and there was no policy for how to use the port connection information, is there any point in fixing this in 3.7? Yes, the connection info might be wrong, but if no one can use it, why should we go to the trouble of backporting it? I do agree this should be in 3.8 and 3.9, I'm just not sure about 3.7. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
