Re: [PATCH 1/6] usb: gadget: atmel: remove unused DMA_ADDR_INVALID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Mar 14, 2013 at 10:01:30AM +0100, Nicolas Ferre wrote:
> On 03/14/2013 09:56 AM, Felipe Balbi :
> > DMA_ADDR_INVALID isn't (and shouldn't) be used
> > anymore, let's remove it.
> > 
> > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> > ---
> >  drivers/usb/gadget/atmel_usba_udc.h | 6 ------
> >  1 file changed, 6 deletions(-)
> > 
> > diff --git a/drivers/usb/gadget/atmel_usba_udc.h b/drivers/usb/gadget/atmel_usba_udc.h
> > index 9791259..d65a618 100644
> > --- a/drivers/usb/gadget/atmel_usba_udc.h
> > +++ b/drivers/usb/gadget/atmel_usba_udc.h
> > @@ -216,12 +216,6 @@
> >  #define EP0_EPT_SIZE		USBA_EPT_SIZE_64
> >  #define EP0_NR_BANKS		1
> >  
> > -/*
> > - * REVISIT: Try to eliminate this value. Can we rely on req->mapped to
> > - * provide this information?
> > - */
> > -#define DMA_ADDR_INVALID (~(dma_addr_t)0)
> > -
> >  #define FIFO_IOMEM_ID	0
> >  #define CTRL_IOMEM_ID	1
> 
> Felipe,
> 
> I see mush more use of DMA_ADDR_INVALID in this driver... Is there
> another patch series that I am missing?

You're missing my other series converting a bunch of the gadget driver
to usb_gadget_map_request:

http://marc.info/?l=linux-usb&m=136187137014524

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux