Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> writes: > On Fri, Feb 15, 2013 at 12:30:11PM +0100, Bjørn Mork wrote: >> Oliver Neukum <oliver@xxxxxxxxxx> writes: >> > On Friday 15 February 2013 08:53:28 Bjørn Mork wrote: >> >> Oliver Neukum <oliver@xxxxxxxxxx> writes: >> > >> >> > We have to let user space recover. To do so we need to indicate when >> >> > exactly we dropped data. >> >> >> >> The problem with that is that this is likely to happen when a client >> >> just doesn't care. It will just continue happily ignoring the read data, >> >> writing new commands or whatever. Then the *next* client opening the >> >> file for reading will see this error. >> > >> > Well, this may be a separate bug. Should the buffer be cleared when >> > we run out of openers? >> >> No. A valid use case, currently working just fine, is using e.g. shell >> commands to sequentially write and read, closing the file inbetween. I >> don't see any reason to suddenly break that. It is a userspace visible >> ABI. > > <snip> > > What ever was decided here? Can someone please send me the patch that > you two agreed would solve this problem? I believe Oliver's patch titled "cdc-wdm: fix buffer overflow" dated Wed, 27 Feb 2013 10:29:02 +0100 was the conclusion to all this. I'll leave it to Oliver to resend it if this is correct. Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
