Re: [PATCH 1/3] usb: phy: isp1301: give it a context structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 08, 2013 at 11:47:13PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 08-03-2013 15:30, Felipe Balbi wrote:
> 
> >this patch is a small preparation to fix
> >isp1301 driver so that other platforms can
> >use it.
> 
> >We're defining our private data structure
> >to represent this device and adding the
> >PHY to the PHY list.
> 
> >Later patches will come implementing proper
> >PHY API and removing bogus code from ohci_nxp
> >and lpc32xx_udc drivers.
> 
> >Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> >---
> >  drivers/usb/phy/phy-isp1301.c | 34 +++++++++++++++++++++++++++++++++-
> >  1 file changed, 33 insertions(+), 1 deletion(-)
> 
> >diff --git a/drivers/usb/phy/phy-isp1301.c b/drivers/usb/phy/phy-isp1301.c
> >index 18dbf7e..36c4d98 100644
> >--- a/drivers/usb/phy/phy-isp1301.c
> >+++ b/drivers/usb/phy/phy-isp1301.c
> [...]
> >@@ -23,14 +32,37 @@ static const struct i2c_device_id isp1301_id[] = {
> >  static struct i2c_client *isp1301_i2c_client;
> >
> >  static int isp1301_probe(struct i2c_client *client,
> >-			 const struct i2c_device_id *i2c_id)
> >+		const struct i2c_device_id *i2c_id)
> 
>    Is this change necessary?

yes.

hehe, seriously now. I'll revert it.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux