On Fri, Mar 08, 2013 at 11:53:21PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 08-03-2013 15:30, Felipe Balbi wrote:
>
> >this patch implements ->init() and ->set_vbus()
> >methods for isp1301 transceiver driver.
>
> >Later patches can now come in order to remove
> >the hackery from ohci-nxp and lpc32xx udc drivers.
>
> >Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> >---
> > drivers/usb/phy/phy-isp1301.c | 59 +++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 59 insertions(+)
>
> >diff --git a/drivers/usb/phy/phy-isp1301.c b/drivers/usb/phy/phy-isp1301.c
> >index 36c4d98..af8f9da 100644
> >--- a/drivers/usb/phy/phy-isp1301.c
> >+++ b/drivers/usb/phy/phy-isp1301.c
> [...]
> >@@ -31,6 +34,60 @@ static const struct i2c_device_id isp1301_id[] = {
> [...]
> >+static int isp1301_phy_init(struct usb_phy *phy)
> >+{
> >+ struct isp1301 *isp = phy_to_isp(phy);
> >+
> >+ /* Disable transparent UART mode first */
> >+ isp1301_clear(isp,ISP1301_I2C_MODE_CONTROL_1, MC1_UART_EN);
>
> You misssed space after comma here.
fixed, thanks.
> >+ isp1301_clear(isp, ISP1301_I2C_MODE_CONTROL_1, ~MC1_SPEED_REG);
> >+ isp1301_write(isp, ISP1301_I2C_MODE_CONTROL_1, MC1_SPEED_REG);
> >+ isp1301_clear(isp, ISP1301_I2C_MODE_CONTROL_2, ~0);
> >+ isp1301_write(isp, ISP1301_I2C_MODE_CONTROL_2, (MC2_BI_DI | MC2_PSW_EN
> >+ | MC2_SPD_SUSP_CTRL));
> >+
> >+ isp1301_clear(isp, ISP1301_I2C_OTG_CONTROL_1, ~0);
> >+ isp1301_write(isp, ISP1301_I2C_MODE_CONTROL_1, MC1_DAT_SE0);
> >+ isp1301_write(isp, ISP1301_I2C_OTG_CONTROL_1, (OTG1_DM_PULLDOWN
> >+ | OTG1_DP_PULLDOWN));
> >+ isp1301_clear(isp, ISP1301_I2C_OTG_CONTROL_1, (OTG1_DM_PULLUP
> >+ | OTG1_DP_PULLUP));
>
> () around | not necessary.
this one I'll keep as it aids readability.
--
balbi
Attachment:
signature.asc
Description: Digital signature
