On Mon, 4 Mar 2013, Stephen Warren wrote: > On 03/04/2013 12:55 AM, Venu Byravarasu wrote: > > Stephen Warren wrote at Thursday, February 28, 2013 11:47 PM: > >> On 02/27/2013 11:36 PM, Venu Byravarasu wrote: > >>> To clear any configurations made by U-Boot on Tegra USB controller, > >>> reset it before init in probe. > >> > >>> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c > >> > >>> @@ -691,6 +692,10 @@ static int tegra_ehci_probe(struct platform_device > >> *pdev) > >>> if (err) > >>> goto fail_clk; > >>> > >>> + tegra_periph_reset_assert(tegra->clk); > >>> + udelay(1); > >>> + tegra_periph_reset_deassert(tegra->clk); > OK, in that case I have no objection to this patch. > > I'd like to hold off on applying this though; I suspect I'll want to > take the Tegra USB patches through the Tegra tree rather than the USB > tree again for the 3.10 kernel cycle. I think I may have screwed the > pooch on the DT binding I set up for the USB controller clocks, and > fixing this may require some Tegra DT changes, which would be easiest > taken through the Tegra tree, and so to reduce conflicts in the USB > code, taking the rest through there migth just be easiest. > > Alan, Greg, if you're OK with this patch now, or for any revised > version, an Ack so I can take it through the Tegra tree would be great, > thanks. I have no other objections. Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
