Re: [PATCH v2 1/5] usb: chipidea: udc: move _ep_queue into an unlocked function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 04, 2013 at 10:44:25AM +0800, Peter Chen wrote:
> On Fri, Mar 01, 2013 at 03:42:23PM +0100, Michael Grzeschik wrote:
> > There is no need to call ep_queue unlocked inside the own driver. We
> > move its functionionality into an unlocked version.
> > 
> > This patch removes potential unlocked timeslots inside
> > isr_setup_status_phase and isr_get_status_response, in which the lock
> > got released just before acquired again inside usb_ep_queue.
> 
> You mean before or after?

I meant what i wrote.

The current lock juggling is as follows:

isr_setup_status_phase
..
unlock
lock   /* acquired inside usb_ep_queue */
..
unlock /* released inside usb_ep_queue */
lock
...

Instead of this, we can stay locked along the whole codepath.

> For other parts, it is ok, you can add:
> Reviewed-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>

Thanks,
Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux