Hi, On Wed, Feb 27, 2013 at 1:59 AM, Felipe Balbi <balbi@xxxxxx> wrote: > Hi, > > On Fri, Feb 22, 2013 at 07:09:39AM +0000, Yuan-Hsin Chen wrote: >> From: Yuan-Hsin Chen <yuanlmm@xxxxxxxxx> >> >> Due to fusb300 controller modification, stall clear procedure should be >> modified consistantly. This patch also fixes software bugs: only >> enter IDMA_RESET when the condition matched and disable corresponding >> PRD interrupt in IDMA_RESET. >> >> >> Signed-off-by: Yuan-Hsin Chen <yhchen@xxxxxxxxxxxxxxxx> > > I have been trying to understand if this is a bug fix or if it can wait > until v3.10. There are a software bug fix and two corresponding fixes to hw register modification in the patch. Should it wait until v3.10? > > Also, according to your commit log, it seems like this patch is doing > more than one thing, which is really frowned upon. Please split it up > into separate logically self-contained changes. While doing that, make > sure that your commit log explains the problem and the solution very > well. Saying that because of a controller modification you need to > change stall clear consistently isn't enough. I will split it up and explain more clearly. Thanks. > > Don't forget to mention how and with which platforms you tested. > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
