On Fri, Mar 01, 2013 at 01:00:16PM -0300, Fabio Estevam wrote:
> Hi Steffen,
>
> On Fri, Mar 1, 2013 at 12:39 PM, Steffen Trumtrar
> <s.trumtrar@xxxxxxxxxxxxxx> wrote:
>
> > This series for imx28:
> >
> > Tested-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
>
> May I see your imx28-evk.dts with USB udc support, please?
>
Okay, I should have written "on a custom imx28 board".
I haven't tried the imx28-evk, but after a quick comparison, this are the things
that I have and the evk doesn't:
- pinctrl for the usbphy
- 'dr_mode = "otg"' in the usb0 node
and in the imx28.dtsi:
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index 13b7053..1eeff3c 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -907,7 +907,8 @@
compatible = "fsl,imx28-usb", "fsl,imx27-usb";
reg = <0x80080000 0x10000>;
interrupts = <93>;
- clocks = <&clks 60>;
+ clocks = <&clks 60>, <&clks 60>, <&clks 60>;
+ clock-names = "ipg", "ahb", "per";
fsl,usbphy = <&usbphy0>;
status = "disabled";
};
@@ -916,7 +917,8 @@
compatible = "fsl,imx28-usb", "fsl,imx27-usb";
reg = <0x80090000 0x10000>;
interrupts = <92>;
- clocks = <&clks 61>;
+ clocks = <&clks 61>, <&clks 61>, <&clks 61>;
+ clock-names = "ipg", "ahb", "per";
fsl,usbphy = <&usbphy1>;
status = "disabled";
};
This and all those ci13xxx_imx patches floating around, I guess.
I think, it would be save to already send the imx28.dtsi patch, although the
chipidea-driver isn't using it in the current mainline, if I see that correct.
Regards,
Steffen
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
