RE: [PATCH v5 3/6] HCD files for the DWC2 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Alan Stern [mailto:stern@xxxxxxxxxxxxxxxxxxx]
> Sent: Wednesday, February 27, 2013 7:22 AM
> 
> On Tue, 26 Feb 2013, Paul Zimmerman wrote:
> 
> > +static struct hc_driver dwc2_hc_driver = {
> > +	.description = "dwc2_hsotg",
> > +	.product_desc = "DWC OTG Controller",
> > +	.hcd_priv_size = sizeof(struct wrapper_priv_data),
> > +
> > +	.irq = _dwc2_hcd_irq,
> > +	.flags = HCD_MEMORY | HCD_USB2,
> > +
> > +	.start = _dwc2_hcd_start,
> > +	.stop = _dwc2_hcd_stop,
> > +	.urb_enqueue = _dwc2_hcd_urb_enqueue,
> > +	.urb_dequeue = _dwc2_hcd_urb_dequeue,
> > +	.endpoint_disable = _dwc2_hcd_endpoint_disable,
> > +	.endpoint_reset = _dwc2_hcd_endpoint_reset,
> > +	.get_frame_number = _dwc2_hcd_get_frame_number,
> > +
> > +	.hub_status_data = _dwc2_hcd_hub_status_data,
> > +	.hub_control = _dwc2_hcd_hub_control,
> > +};
> 
> Paul:
> 
> I'm a little puzzled how this driver manages without a
> clear_tt_buffer_complete callback, or indeed, without calling
> usb_hub_clear_tt_buffer anywhere.  Does the hardware manage this for
> you automatically, or is it an oversight?

Hi Alan,

That involves sending a Clear_TT_Buffer request to the downstream hub,
right? No, the hardware doesn't do that automatically, so I guess this is an
oversight.

I can implement that, but do you know of any practical way to test it?
That would involve inducing some sort of error on the bus during a
split transaction, right?

-- 
Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux