Re: [PATCH 1/9] USB otg: use try_module_get in all usb_get_phy functions and add missing module_put

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Feb 27, 2013 at 01:40:51PM +0100, Marc Kleine-Budde wrote:
> On 02/27/2013 01:31 PM, Felipe Balbi wrote:
> > On Wed, Feb 27, 2013 at 01:27:07PM +0100, Marc Kleine-Budde wrote:
> >> In patch "5d3c28b usb: otg: add device tree support to otg library"
> >> devm_usb_get_phy_by_phandle() was added. It uses try_module_get() to lock the
> >> phy driver in memory. The corresponding module_put() is missing in that patch.
> >>
> >> This patch adds try_module_get() to usb_get_phy() and usb_get_phy_dev().
> >> Further the missing module_put() is added to usb_put_phy().
> >>
> >> Reviewed-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> >> Acked-by: Felipe Balbi <balbi@xxxxxx>
> >> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> >> Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> > 
> > this one doesn't apply to my tree. What did you use as a base ?
> 
> As stated in the cover letter: Greg's usb-next.
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
> 
> I'd really appreciate if this series goes into a single tree. So that
> other chipidea developers can base their work on this.

it eventually will all go through Greg's queue, but drivers/usb/phy and
drivers/usb/otg/ needs to go through my tree so we avoid conflicts
later, sorry.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux