Hi, On Tue, Feb 26, 2013 at 07:23:05PM -0800, Paul Zimmerman wrote: > + retval = dwc2_hcd_init(&dev->dev, hsotg, dev->irq, &dwc2_module_params); > + if (retval) still leaving pci device enabled. > + return retval; > + > + /* > + * WARNING: dwc2_hcd_init() calls usb_create_hcd(), which overwrites > + * the pci_dev drvdata, so we must reset it here > + */ > + pci_set_drvdata(dev, hsotg); > + dev_dbg(&dev->dev, "hsotg=%p\n", hsotg); > + > + /* Install the interrupt handler for the common interrupts */ > + dev_dbg(&dev->dev, "registering common handler for irq%d\n", dev->irq); > + retval = devm_request_irq(&dev->dev, dev->irq, dwc2_handle_common_intr, > + IRQF_SHARED | IRQ_LEVEL, dev_name(&dev->dev), > + hsotg); > + if (retval) and here. fix this and you can add: Reviewied-by: Felipe Balbi <balbi@xxxxxx> -- balbi
Attachment:
signature.asc
Description: Digital signature
