Re: [PATCH v10 6/8] usb: chipidea: imx: add internal vbus regulator control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Darius,

On Wed, Feb 27, 2013 at 04:13:14PM +0800, Peter Chen wrote:
> On Wed, Feb 27, 2013 at 09:07:35AM +0100, Sascha Hauer wrote:
> > On Wed, Feb 27, 2013 at 09:55:10AM +0200, Felipe Balbi wrote:
> > > Hi,
> > > 
> > > On Wed, Feb 27, 2013 at 02:33:17PM +0800, Peter Chen wrote:
> > > > - For host, the vbus should always be on.
> > > > - For otg, the vbus is off defaultly, the vbus needs to be
> > > > turned on/off when usb role switches.
> > > > 
> > > > Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> > > 
> > > one quick question, if chipidea already has an imx glue layer, can I
> > > delete the broken imx_udc ? It doesn't even compile and it's including
> > > headers which don't exist.
> > 
> > This driver handles i.MX1. This one has a gadget only core which is not
> > chipidea compatible. You should ping Darius Augulis <augulis.darius@xxxxxxxxx>
> > if he is willing to put some love into the driver.
> 
> Sascha is correct.

do you plan to put any work on drivers/usb/gadget/imx_udc.c ? It doesn't
even compile since it includes headers which don't exist (and no,
simply removing the include doesn't help).

If nobody is going to work on that driver, I'm thinking about scheduling
it for removal. We can't keep such drivers that nobody cares (and just
break tree compilation) around.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux