Re: [PATCH 063/100] usb: dwc3: add count field to event buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 26, 2013 at 10:51:45PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 26-02-2013 13:34, Felipe Balbi wrote:
> 
> >we can cache the last read value of the event
> >buffer count register on this field, for later
> >handling.
> 
> >Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> >---
> >  drivers/usb/dwc3/core.h | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> >diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> >index e7b0679..5e87cc0 100644
> >--- a/drivers/usb/dwc3/core.h
> >+++ b/drivers/usb/dwc3/core.h
> >@@ -371,6 +371,7 @@ struct dwc3_trb;
> >   * @length: size of this buffer
> >   * @lpos: event offset
> >   * @flags: flags related to this event buffer
> >+ * @count: cache of last read event count register
> >   * @dma: dma_addr_t
> >   * @dwc: pointer to DWC controller
> >   */
> >@@ -379,6 +380,7 @@ struct dwc3_event_buffer {
> >  	unsigned		length;
> >  	unsigned int		lpos;
> >  	unsigned int		flags;
> >+	unsigned int		count;
> 
>    You probably wanted to insert this member after the next #define
> since that one is related to the 'flags' member as follows from the
> previous patch.

makes sense, at least we keep the flags close to the user.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux