Re: test procedure for cdc-wdm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oliver Neukum <oliver@xxxxxxxxxx> wrote:

>Hi,
>
>I am no longer sure about my test procedure for cdc-wdm.
>Do you have a test script?

No, I don't. I probably should have a better system, but I usually just try some operations I consider "normal usage".

>I am also including what I currently have for your review.

Looks fine to me. I am not able to test it right now, as I am on vacation as usual :) This time skiing in the mountains. 

Please submit it if it works for you, and I will test when I am back next week. 

Bjørn


>@@ -478,6 +493,7 @@ retry:
> 			spin_unlock_irq(&desc->iuspin);
> 			goto retry;
> 		}
>+
> 		if (!desc->reslength) { /* zero length read */
>			dev_dbg(&desc->intf->dev, "%s: zero length - clearing WDM_READ\n",
>__func__);
> 			clear_bit(WDM_READ, &desc->flags);

This looks spurious though. You may want to drop that line.






--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux