Re: [PATCH v2 2/2] usb: host: ehci-mxc: Remove dev_info on probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 20 Feb 2013, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> 
> It is not very useful to indicate the the driver is about to be probed.
> 
> Quoting Alan Stern [1]:
> 
> "Plenty of drivers don't include any message like this at all.  You
> might as well get rid of it entirely."
> 
> Remove such dev_info().
> 
> [1] http://marc.info/?l=linux-usb&m=136138896132433&w=2
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> ---
> Changes since v1:
> - Ged rid of dev_info
>  drivers/usb/host/ehci-mxc.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
> index 18c30af..b5b7be4 100644
> --- a/drivers/usb/host/ehci-mxc.c
> +++ b/drivers/usb/host/ehci-mxc.c
> @@ -57,8 +57,6 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
>  	struct device *dev = &pdev->dev;
>  	struct ehci_hcd *ehci;
>  
> -	dev_info(&pdev->dev, "initializing i.MX USB Controller\n");
> -
>  	if (!pdata) {
>  		dev_err(dev, "No platform data given, bailing out.\n");
>  		return -EINVAL;

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux