Hello, [...] > -static struct of_device_id spear_ehci_id_table[] = { > - { .compatible = "st,spear600-ehci", }, > +static struct of_device_id SPEAr_ehci_id_table[] = { > + { .compatible = "st,SPEAr600-ehci", }, > { }, > }; This will break anyone using the documented binding, and anyone with an existing dt will suddenly find their usb support broken. Please don't change this. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html