Hi, On Sat, Feb 09, 2013 at 07:37:47PM -0800, Paul Zimmerman wrote: > - The PCI bus driver has a couple dozen module parameters to control > various optional features of the controller. I realize module parameters optional features ? Are those something you can detect by reading some configuration registers just like we do on dwc3 ? > - There is some code present to implement DRD and OTG support, but it is > incomplete due to the missing peripheral-mode code. maybe we can leave that out for now until peripheral side moves here ? > - There is quite a bit of debug code included. We would like to keep that > until the integration with s3c-hsotg is complete, then most of it can be > stripped out. Just make sure people don't depend on it. Maybe using dev_vdbg() is one way to actually keep it in the driver even after full cleanup is done. See how I implemented dev_vdbg() support for dwc3. -- balbi
Attachment:
signature.asc
Description: Digital signature
