On Tue, Jan 29, 2013 at 12:08:23PM +0200, Roger Quadros wrote: > On 01/29/2013 11:57 AM, Felipe Balbi wrote: > > Hi, > > > > On Tue, Jan 29, 2013 at 11:50:32AM +0200, Roger Quadros wrote: > >> For each port that is in PHY mode we obtain a PHY device using the USB PHY > >> library and put it out of suspend. > >> > >> It is up to platform code to associate the PHY to the controller's > >> port and it is upto the PHY driver to manage the PHY's resources. > >> > >> Also remove wired spacing around declarations we come across. > >> > >> Signed-off-by: Roger Quadros <rogerq@xxxxxx> > > > > ideally, this would be done generically by ehci-hcd.ko itself. Alan, > > would you have objections provided it doesn't break anyone else ? > > > Agreed, and PHY suspend/resume should be done at port granularity. right. > But considering the erratas we have in OMAP EHCI, I would still prefer to > have control of the PHY in ehci-omap. We might even have to do some ULPI > transfers in certain scenarios to work around some of the erratas. fair enough, then let's start with your change and make it more generic later. -- balbi
Attachment:
signature.asc
Description: Digital signature
