On 01/29/2013 11:57 AM, Felipe Balbi wrote: > Hi, > > On Tue, Jan 29, 2013 at 11:50:32AM +0200, Roger Quadros wrote: >> For each port that is in PHY mode we obtain a PHY device using the USB PHY >> library and put it out of suspend. >> >> It is up to platform code to associate the PHY to the controller's >> port and it is upto the PHY driver to manage the PHY's resources. >> >> Also remove wired spacing around declarations we come across. >> >> Signed-off-by: Roger Quadros <rogerq@xxxxxx> > > ideally, this would be done generically by ehci-hcd.ko itself. Alan, > would you have objections provided it doesn't break anyone else ? > Agreed, and PHY suspend/resume should be done at port granularity. But considering the erratas we have in OMAP EHCI, I would still prefer to have control of the PHY in ehci-omap. We might even have to do some ULPI transfers in certain scenarios to work around some of the erratas. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
