On Fri, Jan 25, 2013 at 6:05 PM, Greg KH <greg@xxxxxxxxx> wrote: > On Sat, Jan 26, 2013 at 01:39:50AM +0000, Fangxiaozhi (Franko) wrote: >> >> >> > -----Original Message----- >> > From: Greg KH [mailto:greg@xxxxxxxxx] >> > Sent: Saturday, January 26, 2013 1:45 AM >> > To: Fangxiaozhi (Franko) >> > Cc: Sergei Shtylyov; linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; >> > Xueguiying (Zihan); Linlei (Lei Lin); Yili (Neil); Wangyuhua (Roger, Credit); >> > Huqiao (C); balbi@xxxxxx; mdharm-usb@xxxxxxxxxxxxxxxxxx; >> > sebastian@xxxxxxxxxxxxx >> > Subject: Re: [PATCH 1/2]linux-usb:Define a new macro for USB storage match >> > rules >> > >> > On Fri, Jan 25, 2013 at 04:18:34PM +0400, Sergei Shtylyov wrote: >> > > Hello. >> > > >> > > On 25-01-2013 6:44, fangxiaozhi 00110321 wrote: >> > > >> > > >From: fangxiaozhi <huananhu@xxxxxxxxxx> >> > > >> > > >1. Define a new macro for USB storage match rules: >> > > > matching with Vendor ID and interface descriptors. >> > > >> > > >Signed-off-by: fangxiaozhi <huananhu@xxxxxxxxxx> >> > > >-------------------------------------------------------------------- >> > > > >> > > > diff -uprN linux-3.8-rc4_orig/drivers/usb/storage/usb.c >> > > >linux-3.8-rc4/drivers/usb/storage/usb.c >> > > >--- linux-3.8-rc4_orig/drivers/usb/storage/usb.c 2013-01-22 >> > > >14:12:42.595238727 +0800 >> > > >+++ linux-3.8-rc4/drivers/usb/storage/usb.c 2013-01-22 >> > > >+++ 14:16:01.398250305 +0800 >> > > >@@ -120,6 +120,17 @@ MODULE_PARM_DESC(quirks, "supplemental l >> > > > .useTransport = use_transport, \ >> > > > } >> > > > >> > > >+#define UNUSUAL_VENDOR_INTF(idVendor, cl, sc, pr, \ >> > > >+ vendor_name, product_name, use_protocol, use_transport, \ >> > > >+ init_function, Flags) \ >> > > >+{ \ >> > > >+ .vendorName = vendor_name, \ >> > > >+ .productName = product_name, \ >> > > >+ .useProtocol = use_protocol, \ >> > > >+ .useTransport = use_transport, \ >> > > >+ .initFunction = init_function, \ >> > > >+} >> > > >> > > Shouldn't the field initilaizers be indented with tab, not space? >> > >> > Yes it must. fangxiaozhi, please always run your patches through the >> > scripts/checkpatch.pl tool before sending them out (note, you will have to >> > ignore the CamelCase warnings your patch produces, but not the other >> > ones.) >> > >> -----What's wrong with it? >> -----I have checked the patches with scripts/checkpatch.pl before sending. >> -----There is no other warning or error in my patches except CamelCase warnings. >> -----So what's wrong now? > > Then your email client messed up the patches and put spaces in the code > instead of tabs. Try looking at the message on the mailing list and run > that through checkpatch, it will show you the problems. > > What I received isn't ok, sorry. Fangxiaozhi -- According to the headers of your E-mail, you are using MS Outlook to send your patches. Outlook commonly mangles patches, unfortunately. It is not a very good e-mail client. I suggest one of two options: 1) Setup an alternative mail client. There are many to choose from which will not damage your patches. I personally like 'mutt' (which you should be able to install on your linux machine). Others may be able to recommend ones that work for them; in general, I think you will find that most e-mail clients that run on Linux will be suitable. 2) If you plan on contributing to the linux kernel in the future, it may be worth your time to setup a repo on github that Greg can then directly pull from. All you would need to do is send Greg a "pull request" indicating the URL of the branch in your repo that he should pull from. Greg can then pull directly from your repo, bypassing this issue entirely. Matt -- Matthew Dharm Maintainer, USB Mass Storage driver for Linux -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
