> From: Pratyush Anand [mailto:pratyush.anand@xxxxxx] > Sent: Monday, January 14, 2013 2:30 AM > > Synopsys says: > The HIRD Threshold field must be set to ‘0’ when the device core is > operating in super speed mode. > > This patch implements above statement. > > Signed-off-by: Pratyush Anand <pratyush.anand@xxxxxx> > --- > drivers/usb/dwc3/gadget.c | 31 ++++++++++++++++++------------- > 1 files changed, 18 insertions(+), 13 deletions(-) > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index c9c56a1..74d2496 100644 > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -2156,6 +2156,23 @@ static void dwc3_gadget_conndone_interrupt(struct dwc3 *dwc) > break; > } > > + /* Enable USB2 LPM Capability */ > + > + if ((dwc->revision > DWC3_REVISION_194A) > + && (speed != DWC3_DCFG_SUPERSPEED)) { > + reg = dwc3_readl(dwc->regs, DWC3_DCFG); > + reg |= DWC3_DCFG_LPM_CAP; > + dwc3_writel(dwc->regs, DWC3_DCFG, reg); > + > + reg = dwc3_readl(dwc->regs, DWC3_DCTL); > + reg &= ~(DWC3_DCTL_HIRD_THRES_MASK | DWC3_DCTL_L1_HIBER_EN); > + > + /* TODO: This should be configurable */ > + reg |= DWC3_DCTL_HIRD_THRES(28); > + > + dwc3_writel(dwc->regs, DWC3_DCTL, reg); > + } > + > /* Recent versions support automatic phy suspend and don't need this */ > if (dwc->revision < DWC3_REVISION_194A) { > /* Suspend unneeded PHY */ > @@ -2462,20 +2479,8 @@ int __devinit dwc3_gadget_init(struct dwc3 *dwc) > DWC3_DEVTEN_DISCONNEVTEN); > dwc3_writel(dwc->regs, DWC3_DEVTEN, reg); > > - /* Enable USB2 LPM and automatic phy suspend only on recent versions */ > + /* automatic phy suspend only on recent versions */ > if (dwc->revision >= DWC3_REVISION_194A) { > - reg = dwc3_readl(dwc->regs, DWC3_DCFG); > - reg |= DWC3_DCFG_LPM_CAP; > - dwc3_writel(dwc->regs, DWC3_DCFG, reg); > - > - reg = dwc3_readl(dwc->regs, DWC3_DCTL); > - reg &= ~(DWC3_DCTL_HIRD_THRES_MASK | DWC3_DCTL_L1_HIBER_EN); > - > - /* TODO: This should be configurable */ > - reg |= DWC3_DCTL_HIRD_THRES(28); > - > - dwc3_writel(dwc->regs, DWC3_DCTL, reg); > - > dwc3_gadget_usb2_phy_suspend(dwc, true); > dwc3_gadget_usb3_phy_suspend(dwc, true); > } Acked-by: Paul Zimmerman <paulz@xxxxxxxxxxxx> ��.n��������+%������w��{.n�����{���)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
