On Mon, Jan 14, 2013 at 01:10:56PM +0000, Russell King - ARM Linux wrote: > On Mon, Jan 14, 2013 at 06:12:40PM +0800, Peter Chen wrote: > > @@ -83,15 +84,16 @@ void fsl_udc_clk_finalize(enum fsl_udc_type devtype, > > struct fsl_usb2_platform_data *pdata = pdev->dev.platform_data; > > if (devtype == IMX35_UDC) { > > unsigned int v; > > + void __iomem *phy_regs = ioremap((unsigned long)pdata->regs + > > + MX35_USBPHYCTRL_OFFSET, 512); > > Consider that ioremap() can fail. > Thanks, will check NULL pointer. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html