On 01/11/2013 05:09 PM, Alan Stern wrote:
> On Fri, 11 Jan 2013, Roger Quadros wrote:
>
>>> --- usb-3.7.orig/drivers/usb/host/ehci.h
>>> +++ usb-3.7/drivers/usb/host/ehci.h
>>> @@ -221,6 +221,8 @@ struct ehci_hcd { /* one per controlle
>>> #ifdef DEBUG
>>> struct dentry *debug_dir;
>>> #endif
>>> +
>>> + unsigned long priv[0]; /* platform-specific data */
>>
>> Why can't it be void * ?
>
> It can. I don't see that it makes any difference one way or the other,
> and I don't see any strong reason for changing it to void *.
>
OK. In include/linux/usb/hcd.h it is defined as
unsigned long hcd_priv[0]
__attribute__ ((aligned(sizeof(s64))));
commit explains
USB: fix ehci alignment error
The Kirkwood gave an unaligned memory access error on
line 742 of drivers/usb/host/echi-hcd.c:
"ehci->last_periodic_enable = ktime_get_real();"
might be worth setting to the same.
cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
