Re: [PATCH] usb: musb: Double buffering issues in host mode TX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 04, 2013 at 05:10:33PM +0530, Supriya Karanth wrote:
> From: supriya karanth <supriya.karanth@xxxxxxxxxxxxxx>
> 
> Whenever an URB is programmed for transfer, the TXFIFO
> is flushed. This results in valid packets of the
> previous transfer to get flushed when double buffering
> is enabled (The MUSB_TXCSR_FIFONOTEMPTY bit in TXCSR
> is set indicating that a packet in the FIFO is yet to be sent)
> For ex:- In Host mode Audio, noise is heard in the headset
> when double buffering is enabled on the ISO endpoint.
> The fifo flush is removed for double buffering case.
> The fifo is now flushed only in cases of error or when
> aborting a transfer.
> 
> Also, In Host MSC case, data toggle errors are seen when double
> buffering is enabled on the bulk endpoint. Whenever an URB is
> programmed for transfer, the data toggle is set manually
> resulting in data toggle errors on the bus. Leave the data
> toggle handling upto the hardware in the double buffering case.
> 
> Signed-off-by: supriya karanth <supriya.karanth@xxxxxxxxxxxxxx>
> Signed-off-by: Praveena NADAHALLY <praveen.nadahally@xxxxxxxxxxxxxx>
> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

how was this one tested ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux