On 12/22/2012 02:57 AM, Tejun Heo : > There's no need to test whether a (delayed) work item in pending > before queueing, flushing or cancelling it. Most uses are unnecessary > and quite a few of them are buggy. > > Remove unnecessary pending tests from at91_udc. Only compile tested. > > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx> > Cc: Andrew Victor <linux@xxxxxxxxxxxx> > Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxx> Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx> > Cc: Felipe Balbi <balbi@xxxxxx> > Cc: linux-usb@xxxxxxxxxxxxxxx > --- > Please let me know how this patch should be routed. I can take it > through the workqueue tree if necessary. > > Thanks. > > drivers/usb/gadget/at91_udc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c > index f4a21f6..e81d8a2 100644 > --- a/drivers/usb/gadget/at91_udc.c > +++ b/drivers/usb/gadget/at91_udc.c > @@ -1621,8 +1621,7 @@ static void at91_vbus_timer(unsigned long data) > * bus such as i2c or spi which may sleep, so schedule some work > * to read the vbus gpio > */ > - if (!work_pending(&udc->vbus_timer_work)) > - schedule_work(&udc->vbus_timer_work); > + schedule_work(&udc->vbus_timer_work); > } > > static int at91_start(struct usb_gadget *gadget, > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
