On Mon, 7 Jan 2013, Sachin Kamat wrote: > On Monday, 7 January 2013, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > > On Mon, 7 Jan 2013, Sachin Kamat wrote: > > > >> Exynos OHCI driver does not get registered if generic OHCI driver > >> is also selected as the macro PLATFORM_DRIVER gets re-defined to > >> 'ohci_platform_driver' instead of 'exynos_ohci_driver'. Hence define > >> it separately. > >> > >> Also, silences the following compilation warnings: > >> drivers/usb/host/ohci-hcd.c:1191:0: warning: > >> "PLATFORM_DRIVER" redefined [enabled by default] > >> drivers/usb/host/ohci-hcd.c:1110:0: note: > >> this is the location of the previous definition > >> drivers/usb/host/ohci-exynos.c:276:31: warning: > >> �exynos_ohci_driver� defined but not used [-Wunused-variable] > > > > Why are you selecting both the Exynos and generic OHCI drivers at the > > same time? > > > I was experimenting selecting generic since that option is still available > after selecting Exynos. In case of other drivers like Omap, it worked > whereas in case of exynos it got overridden. Hence the patch to make it > behave like other drivers. I don't know what the OMAP driver does this differently. The only real reason would be if a board had two distinct kinds of OHCI controllers. If the Exynos board doesn't, the simplest approach is to change the Kconfig file so as to make USB_OHCI_EXYNOS mutually exclusive with USB_OHCI_HCD_PLATFORM. However, I would much prefer to see a more general solution, like the one that was recently merged for EHCI. Convert ohci-hcd into a platform-independent library module, and make ohci-exynos, ohci-omap, and so on into separate driver modules that use the library's facilities. I believe Manjunath Goudar <manjunath.goudar@xxxxxxxxxx> may already be working on this, under Deepak Saxena. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
