Dear Peter Chen, > On Thu, Dec 27, 2012 at 08:21:55AM +0100, Marek Vasut wrote: > > Dear Peter Chen, > > > > [...] > > > > > + > > > +#define CI_VBUS_STABLE_TIMEOUT 500 > > > > Shall we not change this to static const int instead ? > > Is it a must? > I find the similar at drivers/usb/core/hub.c [...] No it's not. I was just pondering now that it's a local constant, it might just be like that. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html