Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 21 Dec 2012, Frank Schäfer wrote:

> Anyway, system still wakes up from S3 immediately.

It just occurred to me that not too long ago we learned about a BIOS
bug in ASUS systems that affects EHCI controllers during system suspend
(the workaround is commit dbf0e4c7257f8d684ec1a3c919853464293de66e; you
can look it up if you want).  Perhaps the same bug affects OHCI
controllers too.

It can't hurt to try the test.  Does the patch below make any 
difference?

Alan Stern



Index: usb-3.7/drivers/pci/pci-driver.c
===================================================================
--- usb-3.7.orig/drivers/pci/pci-driver.c
+++ usb-3.7/drivers/pci/pci-driver.c
@@ -716,7 +716,7 @@ static int pci_pm_suspend_noirq(struct d
 	 * Since the value of the COMMAND register doesn't matter once the
 	 * device has been suspended, we can safely set it to 0 here.
 	 */
-	if (pci_dev->class == PCI_CLASS_SERIAL_USB_EHCI)
+	if ((pci_dev->class >> 8) == PCI_CLASS_SERIAL_USB)
 		pci_write_config_word(pci_dev, PCI_COMMAND, 0);
 
 	return 0;

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux