Re: [PATCH v2] drivers/usb/host/ohci* : set urb->hcpriv = NULL immediately, after free it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 19 Dec 2012, Chen Gang wrote:

>   although we can not say it is surely a bug.
>   it is better to set urb->hcpriv = NULL, after finish calling urb_free_priv.
> 
> 
> Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>
> ---
>  drivers/usb/host/ohci-q.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/host/ohci-q.c b/drivers/usb/host/ohci-q.c
> index 7482cfb..88731b7 100644
> --- a/drivers/usb/host/ohci-q.c
> +++ b/drivers/usb/host/ohci-q.c
> @@ -44,6 +44,7 @@ __acquires(ohci->lock)
>  	// ASSERT (urb->hcpriv != 0);
>  
>  	urb_free_priv (ohci, urb->hcpriv);
> +	urb->hcpriv = NULL;
>  	if (likely(status == -EINPROGRESS))
>  		status = 0;
>  

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux