On Friday 14 December 2012 13:35:04 Steve Glendinning wrote: > Thanks Ming, I've updated this. Very good. Good catch Ming. > > IMO, it is better to keep smsc95xx_info.manage_power as NULL > > for devices without FEATURE_AUTOSUSPEND, so that fewer code > > and follow the current .mange_power usage(see its comment). > > > > Currently, if the function pointer of manage_power is set, it means that > > the device supports USB autosuspend, but your trick will make the manage_power() can return errors. So the assumption was always strictly speaking invalid. > > assumption not true for some smsc devices. > > Oliver? On second thought, I think that if a driver can do manage_power(), even only for a subset of devices, it should implement it. Doctoring the table of methods is very, very ugly, especially as this not protected by a lock. But this is not nice. We need a better way. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
