On 11 December 2012 16:13, Ming Lei <ming.lei@xxxxxxxxxxxxx> wrote: > On Tue, Dec 11, 2012 at 11:26 PM, Steve Glendinning > <steve.glendinning@xxxxxxxxxxx> wrote: >> + >> + if (on) >> + usb_autopm_get_interface_no_resume(dev->intf); >> + else >> + usb_autopm_put_interface_no_suspend(dev->intf); > > The above line should be > > usb_autopm_put_interface(dev->intf); Thanks Ming, I've updated this. > IMO, it is better to keep smsc95xx_info.manage_power as NULL > for devices without FEATURE_AUTOSUSPEND, so that fewer code > and follow the current .mange_power usage(see its comment). > > Currently, if the function pointer of manage_power is set, it means that > the device supports USB autosuspend, but your trick will make the > assumption not true for some smsc devices. Oliver? -- Steve Glendinning -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
