Re: [PATCH 1/1] usb: dwc3: Use devm_kzalloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Dec 12, 2012 at 05:08:09PM +0530, Sachin Kamat wrote:
> On 12 December 2012 16:51, Felipe Balbi <balbi@xxxxxx> wrote:
> > On Wed, Dec 12, 2012 at 04:13:15PM +0530, Sachin Kamat wrote:
> >> devm_kzalloc is device managed and makes error handling and cleanup
> >> simpler. While at it also fixed the return value when platform_device_alloc
> >> failed in probe function.
> >>
> >> Cc: Anton Tikhomirov <av.tikhomirov@xxxxxxxxxxx>
> >> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> >
> > what's wrong with http://www.spinics.net/lists/linux-usb/msg74326.html ?
> 
> Looks good to me though the creation of '*dev' was not really necessary.
> I had not looked at the above patch. Please ignore mine.

yeah, it's definitely not necessary and GCC will optimize it anyway ;-)

cheers

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux