On 12/05/2012 05:00 PM, Marc Kleine-Budde wrote: > On 12/05/2012 04:49 PM, Oliver Hartkopp wrote: >> On 05.12.2012 11:13, Wolfgang Grandegger wrote: >> >>>> + outmsg.command = USB_8DEV_OPEN; >>>> + outmsg.opt1 = USB_8DEV_BAUD_MANUAL; >>>> + outmsg.data[0] = (bt->prop_seg + bt->phase_seg1); >>> >>> Minor issue. Brackets not needed. >>> >>>> + outmsg.data[1] = bt->phase_seg2; >>>> + outmsg.data[2] = bt->sjw; >>>> + >> >> That's correct from a compilers point of view. >> But in this case i would preserve the [0] as it is better to read in >> conjunction with the two lines below ( ..[1] ..[2] ) >> >> The semantic has to be understood by humans ;-) > > I think Wolfgang was talking about the round bracket not the square > bracket. :D Yep. Sorry for confusion. Wolfgang. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
