Re: [PATCH v4] usb_8dev: Add support for USB2CAN interface from 8 devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05.12.2012 11:13, Wolfgang Grandegger wrote:

+    outmsg.command = USB_8DEV_OPEN;
+    outmsg.opt1 = USB_8DEV_BAUD_MANUAL;
+    outmsg.data[0] = (bt->prop_seg + bt->phase_seg1);

Minor issue. Brackets not needed.

+    outmsg.data[1] = bt->phase_seg2;
+    outmsg.data[2] = bt->sjw;
+

That's correct from a compilers point of view.
But in this case i would preserve the [0] as it is better to read in conjunction with the two lines below ( ..[1] ..[2] )

The semantic has to be understood by humans ;-)

Regards,
Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux