Re: [PATCH 06/16] usb/gadget: convert source sink and loopback to new function interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 20, 2012 at 11:53:02PM +0100, Michal Nazarewicz wrote:
> > * Felipe Balbi | 2012-11-20 14:14:47 [+0200]:
> >> now this looks awfully wrong. Why don't you just expose the modules to
> >> userland (in fact they already are) and if user wants to change
> >> something it needs to do it via sysfs before enabling the function ?
> 
> On Tue, Nov 20 2012, Sebastian Andrzej Siewior wrote:
> > This isn't that easy. buflen & qlen here are used for memory allocation.
> > A change here would require to purge all usb_requests and re-allocate
> > them.
> 
> I think that what Felipe means is to let user set the values in sysfs
> before the function is enabled.  Once the function is added to some
> gadget, the values become read only.

spot on.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux