One more, I checked it again "Documentation/SubmittingPatches" In the 12) Sign your work You can find the following paragraphs. "Some people also put extra tags at the end. They'll just be ignored for now, but you can do this to mark internal company procedures or just point out some special detail about the sign-off." And 13) When to use Acked-by: and Cc: "The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path." I used Signed-off as our contribution to open source from our teams. Of course some codes are written by me with correct Signed-off Thank you, Kyungmin Park > -----Original Message----- > From: Kyungmin Park [mailto:kyungmin.park@xxxxxxxxxxx] > Sent: Friday, November 23, 2012 8:05 PM > To: 'Sebastian Andrzej Siewior'; 'Michal Nazarewicz' > Cc: 'Andrzej Pietrasiewicz'; 'linux-usb@xxxxxxxxxxxxxxx'; 'Felipe Balbi'; > 'Greg Kroah-Hartman'; 'Joel Becker'; 'Marek Szyprowski' > Subject: RE: [RFCv4 PATCH 01/13] usb: composite: add make_group and > add_function operations > > Hi, > > > -----Original Message----- > > From: Sebastian Andrzej Siewior [mailto:bigeasy@xxxxxxxxxxxxx] > > Sent: Friday, November 23, 2012 7:17 PM > > To: Michal Nazarewicz > > Cc: Andrzej Pietrasiewicz; linux-usb@xxxxxxxxxxxxxxx; 'Kyungmin Park'; > > 'Felipe Balbi'; 'Greg Kroah-Hartman'; 'Joel Becker'; Marek Szyprowski > > Subject: Re: [RFCv4 PATCH 01/13] usb: composite: add make_group and > > add_function operations > > > > On 11/22/2012 09:48 PM, Michal Nazarewicz wrote: > > > I think neither is correct. The reviewed-by tag implies that the > > > person did a careful review of the code as per “Reviewer's statement > > > of oversight” (see Documentation/SubmittingPatches). > > > > > > What actually happens is Kyungmin giving a green light to shipping the > > > patch from copyright stand-point since Samsung is copyright holder and > > > Andrzej has no power to say weather he can or cannot release the code. > > > > > > So logical path the code took was: > > > > > > Andrzej -> Kyungmin -> Andrzej -> linux-usb > > > > Aha. So is Kyungmin a lawyer and not a hacker as I assumed in the first > > place. > > > > > If you look at other patches coming from SPRC (including mine while I > > > was working for Samsung) they all have the same Signed-off schema > > > where the first line is of the author and second is of Kyungmin. > > > > This together with the statement above explains a lot to me. I always > saw > > that and wondered how much code he can write. I assumed that Kyungmin > was > > some kind of kick-ass hacker that knows all the chips very well and > > therefore writes all of the Samsung code ahead of HW and then is too > busy > > with other stuff and so other people in his team push his patches > mainline > > and deal with the review. > > I know that other companies work like that, where a small group of > people > > does the bring-up and then others take their code and try to merge > > upstream. And this impressed me because Kyungmin is a person and not a > > small group. > > > > Anyway. > > Signed-off indicates that he was involved in code development but he was > > not. As it seems it me, his OKAY is very important why not add him as > > > > Acked-By: ... [copyright] > > > > I added the [copyright] as the subsystem since he did Ack only a part of > > the patch, not the functionality etc. I know that (now) but others might > > not. > > Even though all codes are not tested at internal tree, but most codes are > tested internal tree. And these internal tree is managed by me. > That's reason to add Signed-off as internal tree maintainer. > And most of codes from us, I checked it by internal approval process. If > you don't feel it's not correct Signed-off scheme. > No problem to replace it with Reviewed-by or Acked-by. > > Thank you, > Kyungmin Park > > > > > Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
