RE: [RFCv4 PATCH 01/13] usb: composite: add make_group and add_function operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> * Andrzej Pietrasiewicz | 2012-11-22 13:06:55 [+0100]:
>> Using configfs to create/configure a usb gadget requires
>> providing a method to create config group for a usb function
>> and a wrapper for usb_add_function.
>>
>> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>
>> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>

On Thursday, November 22, 2012 3:55 PM Sebastian Andrzej Siewior wrote:
> Just a side note: The signed-off here should show the way patch has been
> passed. Based on this it looks like you stopped working on it and passed
> it over to Kyungmin. That is okay but since you are posting it I guess
> it is the other way around.

On Thu, Nov 22 2012, Andrzej Pietrasiewicz wrote:
> I guess it should be:
>
> Reviewed-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>

I think neither is correct.  The reviewed-by tag implies that the person
did a careful review of the code as per “Reviewer's statement of
oversight” (see Documentation/SubmittingPatches).

What actually happens is Kyungmin giving a green light to shipping the
patch from copyright stand-point since Samsung is copyright holder and
Andrzej has no power to say weather he can or cannot release the code.

So logical path the code took was:

	Andrzej -> Kyungmin -> Andrzej -> linux-usb

If you look at other patches coming from SPRC (including mine while
I was working for Samsung) they all have the same Signed-off schema
where the first line is of the author and second is of Kyungmin.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--

Attachment: pgpwCBTZJgUsa.pgp
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux